Fix broken basic auth with long username/password #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With long usernames and passwords (like those produced by Learning Locker), the base64.encodestring produces multiline digest for the Auth header, thus breaking the requests. This patch uses the better b64encode, which doesn't add any spurious newlines.
|
+1. This fixed #86 for me. Thanks! |
Member
|
@RedGlow can you remove the comment preceding the code change since the newline is no longer existing (so not needing to be removed)? Otherwise I'm 👍 on this. |
This was referenced Jun 1, 2015
Member
|
Closing for #88 which takes care of the comment. (Trying to fasttrack this.) |
Contributor
Author
|
Sorry, read the updates only now. I see you already removed the line, so I suppose there's nothing more for me to do ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With long usernames and passwords (like those produced by Learning
Locker), the base64.encodestring produces multiline digest for the Auth
header, thus breaking the requests. This patch uses the better
b64encode, which doesn't add any spurious newlines.