Skip to content

fix(move): move command doesnt sync permissions#244

Merged
Akinator31 merged 2 commits intomainfrom
243-move-command-doesnt-sync-permissions
Nov 23, 2025
Merged

fix(move): move command doesnt sync permissions#244
Akinator31 merged 2 commits intomainfrom
243-move-command-doesnt-sync-permissions

Conversation

@Akinator31
Copy link
Copy Markdown
Member

This pull request introduces several improvements to how channels are moved between categories in the rustmail project, focusing on permission management and error handling. The main changes include updating the version, refactoring functions to use custom error types, and ensuring that permission overwrites are preserved when moving channels.

Permission management improvements:

  • Added the get_category_permissions_overwrites function in category.rs to retrieve permission overwrites from a category before moving a channel, ensuring permissions are correctly transferred.
  • Updated move_channel_to_category_by_msg and move_channel_to_category_by_command_option in common.rs to apply category permission overwrites when moving channels, improving consistency and security.

Error handling and type safety:

  • Refactored functions to use the custom ModmailResult and ModmailError types instead of raw Serenity errors, standardizing error handling across the codebase. [1] [2] [3]

General updates:

  • Updated the project version in Cargo.toml from 0.1.1 to 1.0.3 to reflect these significant changes.

@Akinator31 Akinator31 self-assigned this Nov 23, 2025
@Akinator31 Akinator31 linked an issue Nov 23, 2025 that may be closed by this pull request
@Akinator31 Akinator31 merged commit 6eba9ee into main Nov 23, 2025
6 checks passed
@Akinator31 Akinator31 deleted the 243-move-command-doesnt-sync-permissions branch November 23, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move command doesn't sync permissions

1 participant