fix(move): move command doesnt sync permissions#244
Merged
Akinator31 merged 2 commits intomainfrom Nov 23, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to how channels are moved between categories in the
rustmailproject, focusing on permission management and error handling. The main changes include updating the version, refactoring functions to use custom error types, and ensuring that permission overwrites are preserved when moving channels.Permission management improvements:
get_category_permissions_overwritesfunction incategory.rsto retrieve permission overwrites from a category before moving a channel, ensuring permissions are correctly transferred.move_channel_to_category_by_msgandmove_channel_to_category_by_command_optionincommon.rsto apply category permission overwrites when moving channels, improving consistency and security.Error handling and type safety:
ModmailResultandModmailErrortypes instead of raw Serenity errors, standardizing error handling across the codebase. [1] [2] [3]General updates:
Cargo.tomlfrom0.1.1to1.0.3to reflect these significant changes.