refactor(command): refactor close command#249
Merged
Akinator31 merged 2 commits intomainfrom Nov 24, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the scheduled thread closure logic in both the slash and text command implementations. The main changes are the extraction of a reusable
format_durationfunction, improved user feedback when replacing an existing scheduled closure, and a significant simplification of how category and permission information is determined and passed around. Additionally, the scheduling logic for closures has been centralized for maintainability.User feedback improvements:
format_durationfunction for consistency.Code simplification and maintainability:
Scheduling logic refactor:
schedule_onefunction, replacing the previous inlined and nestedtokio::spawnlogic, making it easier to maintain and extend.General code improvements:
format_durationfunction for consistency and readability.These changes improve user experience, reduce code duplication, and make the scheduling logic easier to understand and maintain.