update PINCache #17
Merged
update PINCache #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older PINCache causes runtime erorr sometimes. To avoid this problem, set version of PINCache. refs: TextureGroup/Texture#769
Collaborator
|
Is there some new feature of new PinCache version you like to use @fumito-ito ? I not specified dependencies version so users can choose the version they want. |
Contributor
Author
|
@dangthaison91 No. According to TextureGroup/Texture#769, the runtime error |
dangthaison91
requested changes
Apr 24, 2018
Cartfile
Outdated
|
|
||
| github "RxSwiftCommunity/RxDataSources" | ||
| github "texturegroup/texture" | ||
| github "pinterest/PINCache" "3.0.1-beta.6" |
Collaborator
There was a problem hiding this comment.
Can we allow user use version 3.0 or later by using ~> 1.0 or >= 1.0
Contributor
Author
There was a problem hiding this comment.
It will be better than mine. I fixed it.
with submodule reference
dangthaison91
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older PINCache causes runtime erorr sometimes.
To avoid this problem, set newer version of PINCache.
refs: TextureGroup/Texture#769