Repository navigation
Documentation Feedback : Contributor Onboarding Experience #441
Replies: 1 comment 2 replies
|
Hi @Prachi-Gupta2808. Thank you for the input!
Yes. #439 will implement something that will make it much easier to set up the project because it'll contain a command that sets it all up for the user. #303 mentions setting up Git hooks, which would be a good idea during that setup phase as well - the only problem is ensuring that the hooks remain usable regardless of the OS (I make my commits on Windows 11, but run the code in the Docker container).
That sounds a lot like something I may have forgotten to update when I did the #250 refactor. This project used to be just the React example app before I realized that it would be a good idea to make it available for other people who share similar problems to what I faced (most raster-to-SVG libraries don't have good support for natural images because they were created to improve blocky synthetic images - see here: Potrace examples, imagetracerjs example, other examples). Our library is basically the opposite of theirs: it doesn't handle synthetic images as well as theirs, but it beats most at maintaining important details (depending on how you configured it, of course). We will definitely need to change the documentation to resolve those mistakes. @coderabbitai please create an issue for this point (2) to get the documentation fixed. There are broken links and outdated content.
I think this ties into the point I made about #250 because
It will definitely need to be updated, but I'm not sure about the workers. I did mention that I'm considering removing them in #433 to make the library simpler and give more power to our users.
Basically, we need to remove the |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Documentation Feedback
Hello @Ryan-Millard and @Krasner As promised, here's my feedback after going through the docs ("old"/current version) over the past couple of days and contributing.
What worked well
useWasmWorkerandwasmWorker.jsreference pages were genuinely excellent, they helped me understand the WASM/JS memory model deeply.Gaps I ran into
1. WASM build step missing from Getting Started
The Getting Started guide doesn't mention how to build the WASM module. I had to ask in #394 and was given:
This should probably be added as a step in Getting Started, since without it
packages/js/build-wasmdoesn't exist and nothing works.Krasner mentioned that PR #439 (introducing a
Justfile) should address this by bundling setup commands like this into something simpler, e.g.just init-img2num. Linking it here so it's tracked alongside this feedback.2. Reference docs describe an architecture that doesn't match the current codebase
Several reference pages (Vite Configuration, WASM Reference overview) describe a
src/wasm/modules/{name}structure withnpm run build-wasm/npm run build-wasm:debugscripts and auto-rebuild Vite plugins. However, the actual current codebase usesbindings/js+packages/js, built via CMake/Emscripten directly (emcmake cmake+cmake --build), not the structure described in these docs. This was confusing since I assumed these reference pages matched the current code.3. Broken links in Editor page test docs
The Editor Tests reference page links to:
but the actual path is under
example-apps/react-js/src/pages/Editor/Editor.test.jsx, so these links 404.4. wasmWorker.js docs don't mention Node.js support
After #433 adds
worker_threadssupport for Node.js, (and you guys do the required changes) thewasmWorker.jsreference page should probably be updated to document the dual environment behavior (browser Worker vsworker_threads, and howisNode.jsis used to detect environment).Question
I was also curious about the "Next" version of the docs what's the plan with it? Is it for an upcoming architecture redesign, or are you guys thinking of shifting to next.js, or is it something else?
Happy to help fix any of these, let me know which ones make sense to tackle first and your reviews if I am pointing out something wrong.
All reactions