Merged
Conversation
There are some design issues with this action, so until we work them out, we'll remove this code from the repository to avoid folks from taking a dependency on it.
#2613) ### What this PR does This PR introduces a new public method, remove_conversation(conversation_id: Uuid), to the ConversationManager. This allows consumers of the codex-core library to manually remove a conversation from the manager's in-memory storage. ### Why this change is needed I am currently adapting the Codex client to run as a long-lived server application. In this server environment, ConversationManager instances persist for extended periods, and new conversations are created for each incoming user request. The current implementation of ConversationManager stores all created conversations in a HashMap indefinitely, with no mechanism for removal. This leads to unbounded memory growth in a server context, as every new conversation permanently occupies memory. While an automatic TTL-based cleanup mechanism could be one solution, a simpler, more direct remove_conversation method provides the necessary control for my use case. It allows my server application to explicitly manage the lifecycle of conversations, such as cleaning them up after a request is fully processed or after a period of inactivity is detected at the application level. This change provides a minimal, non-intrusive way to address the memory management issue for server-like applications built on top of codex-core, giving developers the flexibility to implement their own cleanup logic. Signed-off-by: M4n5ter <m4n5terrr@gmail.com> Co-authored-by: Michael Bolin <mbolin@openai.com>
Use emoji variation selector (VS16) for the keyboard icon so it consistently renders as emoji (⌨️) rather than text (⌨) across terminals. Touches TUI command rendering for unknown parsed commands. No behavior change beyond display.
#2717) This pr addresses the fix for #2713 ### Changes: - Added key handler for `Alt+Ctrl+H` → `delete_backward_word()` - Added test coverage in `delete_backward_word_alt_keys()` that verifies both: - Standard `Alt+Backspace` binding continues to work - New `Alt+Ctrl+H` binding works correctly for backward word deletion ### Testing: The test ensures both key combinations produce identical behavior: - Delete the previous word from "hello world" → "hello " - Cursor positioned correctly after deletion ### Backward Compatibility: This change is backward compatible - existing `Alt+Backspace` functionality remains unchanged while adding support for the terminal-specific `Alt+Ctrl+H` variant
This fixes a bug where if you ran /diff while at turn was running, transcript lines would be added to the end of the diff view. Also, refactor to make this kind of issue less likely in future.
before: <img width="295" height="266" alt="Screenshot 2025-08-26 at 5 05 03 PM" src="https://github.com/user-attachments/assets/3e876f08-26d0-407e-a995-28fd072e288f" /> after: <img width="295" height="129" alt="Screenshot 2025-08-26 at 5 05 30 PM" src="https://github.com/user-attachments/assets/2a019d52-19ed-40ef-8155-4f02c400796a" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )