Generate paket.lock for all possible template options#139
Merged
theimowski merged 26 commits intoSAFE-Stack:masterfrom Aug 10, 2018
Merged
Generate paket.lock for all possible template options#139theimowski merged 26 commits intoSAFE-Stack:masterfrom
theimowski merged 26 commits intoSAFE-Stack:masterfrom
Conversation
Closed
Member
|
Looks very interesting! Will this generate the lock files in advance or when people create a new project from the template? |
Member
Author
|
it creates the lock files before packaging up the NuGet, so they are present in the template already |
Member
|
How many are there currently? |
Member
Author
3 x 2 x 2 x 2 = 24 EDIT: wrong snippet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is to write couple of Fake helper targets for dealing with various paket.lock files in the template.
Because the paket.lock will always have 3 groups:
we can treat each of the group separately to minimize total number of paket.lock permutations.
Workflow in this PR for working with paket.lock
GenPaketLockFilesFake target can generate lock files for representative number of template options, split it for each group and save in./Content/{Group}directoryBuildPaketLockFilescan take the lock files from corresponding./Content/{Group}dirs and build all permutations of lock files in./Content. This target is now dependency ofPacktargetRemovePaketLockFilesoccurs afterPacktarget so that the git repo is not littered with generated paket.lock filesGenJsonDefinitionstarget can be invoked to print conditions needed to be placed intotemplate.jsonmanifestUpdatePaketLockFilesupdates all paket lock files (can pass in specific group name(s) as target parameter)Refers to #66