Skip to content

Update dependencies#151

Merged
theimowski merged 7 commits intoSAFE-Stack:masterfrom
0x53A:update-locks
Aug 31, 2018
Merged

Update dependencies#151
theimowski merged 7 commits intoSAFE-Stack:masterfrom
0x53A:update-locks

Conversation

@0x53A
Copy link
Copy Markdown
Contributor

@0x53A 0x53A commented Aug 30, 2018

fixes #150

@theimowski
Copy link
Copy Markdown
Member

theimowski commented Aug 30, 2018

Looks like projects created with --remoting option are failing to build

@0x53A
Copy link
Copy Markdown
Contributor Author

0x53A commented Aug 30, 2018

CI is green. Anything you want me to check manually?

@0x53A 0x53A changed the title [WIP] Update dependencies Update dependencies Aug 30, 2018
@theimowski theimowski merged commit 34e927a into SAFE-Stack:master Aug 31, 2018
@theimowski
Copy link
Copy Markdown
Member

Thanks, I'll release it when back from holidays - around 20.09

Apart from the necessary --remoting changes and running paket in build script, do you have any comments to the workflow for updating paket dependencies?

@0x53A
Copy link
Copy Markdown
Contributor Author

0x53A commented Aug 31, 2018

The update worked perfectly - I just executed UpdatePaketLockFiles and it did its thing.

Testing all permutations is a bit complicated, but I guess for that you have CI.

Just one comment: the order of targets looks at first glance "wrong":

It first installs the template, then updates the lockfiles.

SAFE-template/build.fsx

Lines 360 to 361 in 34e927a

"Install"
==> "UpdatePaketLockFiles"

I guess it should do the reverse - first update, then pack and install?

@theimowski
Copy link
Copy Markdown
Member

UpdatePaketLockFiles was not supposed to be in any build chain, but rather as a standalone step. The dependency on "Install" is there only to ensure that current template is installed before creating projects and paket.lock files to update

@0x53A 0x53A deleted the update-locks branch May 21, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New project fails after paket update

2 participants