Skip to content

update dependencies (nuget and npm)#199

Merged
theimowski merged 13 commits intoSAFE-Stack:masterfrom
0x53A:update-dependencies
Dec 18, 2018
Merged

update dependencies (nuget and npm)#199
theimowski merged 13 commits intoSAFE-Stack:masterfrom
0x53A:update-dependencies

Conversation

@0x53A
Copy link
Copy Markdown
Contributor

@0x53A 0x53A commented Dec 11, 2018

I haven't run any manual tests, that's what CI is for

@0x53A
Copy link
Copy Markdown
Contributor Author

0x53A commented Dec 12, 2018

FontAwesome was removed from Fulma and added to its own package: Fulma/Fulma#166 (comment)

For now I was lazy and locked Fulma to the old version.

@0x53A 0x53A changed the title run UpdatePaketLockFiles update dependencies (nuget and npm) Dec 12, 2018
@0x53A
Copy link
Copy Markdown
Contributor Author

0x53A commented Dec 12, 2018

Locally green.

grafik

good night 💤💤💤

please note that I haven't done any other manual tests.

@theimowski
Copy link
Copy Markdown
Member

Thanks for this! Can we add FontAwesome explicitly as well please? See #198

@0x53A
Copy link
Copy Markdown
Contributor Author

0x53A commented Dec 12, 2018

I have no clue how FA works.

Can you tell me what to replace the old

Icon.faIcon [ ]
  [ Fa.icon Fa.I.Github; Fa.fw ]

with?

@0x53A
Copy link
Copy Markdown
Contributor Author

0x53A commented Dec 12, 2018

@isaacabraham Do you know what the new syntax is? Never used FA.

@isaacabraham
Copy link
Copy Markdown
Member

@0x53A It's the same syntax as before, but in new Elmish you need to add the Fable.FontAwesome.Free package as well (and open Fable.FontAwesome I believe). Otherwise it should be as before (except there are more icons now as it goes against FA 5, not 4).

@0x53A
Copy link
Copy Markdown
Contributor Author

0x53A commented Dec 13, 2018

@isaacabraham I tried it, but the new package seems to have completely different content.

grafik

@isaacabraham
Copy link
Copy Markdown
Member

cc @MangelMaxime

@MangelMaxime
Copy link
Copy Markdown

You can check out the migration guide and new documentation:
https://mangelmaxime.github.io/Fulma/#blog-viewer?file=blog/articles/fulma_2.0.0.md

[ Icon.icon
[ ]
[ Fa.icon Fa.I.BellO ] ]
[ Fa.i [ Fa.Solid.Bell ] [] ] ]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BellO => Bell ?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BellO replacement is Fa.Regular.Bell

You can see the list of all the icon name change between version 4 and 5 here

[ Icon.faIcon [ ]
[ Fa.icon Fa.I.Github; Fa.fw ]
[ Icon.icon [ ]
[ Fa.i [Fa.Brand.Github] [] ]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does Fa.fw do, and what is the replacement?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fa.fw stand for fiwed-width

The replacement is Fa.FixedWidth

[ Icon.faIcon [ ]
[ Fa.icon Fa.I.Github; Fa.fw ]
[ Icon.icon [ ]
[ Fa.i [Fa.Brand.Github] [] ]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does Fa.fw do, and what is the replacement?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fa.fw stand for fiwed-width

The replacement is Fa.FixedWidth

Comment thread Content/src/Client/Client.fs
card Fa.I.IdCardO "Tempor orci dapibus ultrices in." "Ut venenatis tellus in metus vulputate. Amet consectetur adipiscing elit pellentesque. Sed arcu non odio euismod lacinia at quis risus. Faucibus turpis in eu mi bibendum neque egestas cmonsu songue. Phasellus vestibulum lorem sed risus."
card Fa.I.Rocket "Leo integer malesuada nunc vel risus." "Imperdiet dui accumsan sit amet nulla facilisi morbi. Fusce ut placerat orci nulla pellentesque dignissim enim. Libero id faucibus nisl tincidunt eget nullam. Commodo viverra maecenas accumsan lacus vel facilisis." ]
[ card Fa.Solid.Paw "Tristique senectus et netus et." "Purus semper eget duis at tellus at urna condimentum mattis. Non blandit massa enim nec. Integer enim neque volutpat ac tincidunt vitae semper quis. Accumsan tortor posuere ac ut consequat semper viverra nam."
card Fa.Solid.IdCard "Tempor orci dapibus ultrices in." "Ut venenatis tellus in metus vulputate. Amet consectetur adipiscing elit pellentesque. Sed arcu non odio euismod lacinia at quis risus. Faucibus turpis in eu mi bibendum neque egestas cmonsu songue. Phasellus vestibulum lorem sed risus."
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IdCardO => IdCard?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IdCardO replacement is Fa.Regular.IdCard

You can see the list of all the icon name change between version 4 and 5 here

@theimowski theimowski merged commit ede5314 into SAFE-Stack:master Dec 18, 2018
@theimowski
Copy link
Copy Markdown
Member

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants