Skip to content

Set Fable variable on client project#262

Merged
theimowski merged 1 commit intomasterfrom
forki-patch-4
May 20, 2019
Merged

Set Fable variable on client project#262
theimowski merged 1 commit intomasterfrom
forki-patch-4

Conversation

@forki
Copy link
Copy Markdown
Member

@forki forki commented May 16, 2019

this makes the ionide aware of the fact that this is a fable project.
This is needed if #if FABLE_COMPILER directives that are sometimes needed for SSR - especially when you want to have Thoth.Fetch in one end and Thoth.Net on the other.

/cc @Krzysztof-Cieslak @isaacabraham @MangelMaxime

@forki
Copy link
Copy Markdown
Member Author

forki commented May 16, 2019

For clarification: Fable itselft sets the variable during compilation. So it always worked fine. It's just that there are edge cases where the IDE shows the wrong branch and that's confusing as fuck

@forki forki requested a review from theimowski May 16, 2019 16:03
@theimowski
Copy link
Copy Markdown
Member

I haven't yet used SSR, but if that helps then I'm happy to pull that in.

Just wondering whether we might have a more general IDE-related issue with those constants:
Say you use them in Shared.fs which is shared between Client and Server - should IDE respect constants defined in Client or Server project?

I have a similar issue in commercial project, but based on the OS-specific constants (#if WINDOWS, #if OSX etc..)

@theimowski theimowski merged commit 0226f9c into master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants