Set Fable variable on client project#262
Merged
theimowski merged 1 commit intomasterfrom May 20, 2019
Merged
Conversation
Member
Author
|
For clarification: Fable itselft sets the variable during compilation. So it always worked fine. It's just that there are edge cases where the IDE shows the wrong branch and that's confusing as fuck |
Member
|
I haven't yet used SSR, but if that helps then I'm happy to pull that in. Just wondering whether we might have a more general IDE-related issue with those constants: I have a similar issue in commercial project, but based on the OS-specific constants ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this makes the ionide aware of the fact that this is a fable project.
This is needed if
#if FABLE_COMPILERdirectives that are sometimes needed for SSR - especially when you want to have Thoth.Fetch in one end and Thoth.Net on the other./cc @Krzysztof-Cieslak @isaacabraham @MangelMaxime