Remove font awesome from paket#471
Merged
theimowski merged 2 commits intomasterfrom Aug 23, 2021
Merged
Conversation
|
I personally found Font Awesome too quickly evolving to have some strongly-typed API wrapping it so I just use an npm package or direct link to CDN. |
Member
Author
|
That's basically what the template does, aside from still include the NuGet package. As we've now moved over to Feliz.Bulma, I'm not sure what sense it makes to keep it. |
Member
|
yeah let's get it removed - noticed there's a recipe in docs that has inconsistent instructions between default and minimal: https://github.com/SAFE-Stack/docs/blob/master/docs/recipes/ui/add-fontawesome.md#3-code-snippet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456. If there's a way to use these libraries seamlessly with Feliz.Bulma, I'm happy for this not to go in and to add a recipe instead? cc @Dzoukr @Zaid-Ajaj