Skip to content

Remove font awesome from paket#471

Merged
theimowski merged 2 commits intomasterfrom
remove-fontawesome-fable
Aug 23, 2021
Merged

Remove font awesome from paket#471
theimowski merged 2 commits intomasterfrom
remove-fontawesome-fable

Conversation

@isaacabraham
Copy link
Copy Markdown
Member

Fixes #456. If there's a way to use these libraries seamlessly with Feliz.Bulma, I'm happy for this not to go in and to add a recipe instead? cc @Dzoukr @Zaid-Ajaj

@Dzoukr
Copy link
Copy Markdown

Dzoukr commented Aug 21, 2021

I personally found Font Awesome too quickly evolving to have some strongly-typed API wrapping it so I just use an npm package or direct link to CDN.

@isaacabraham
Copy link
Copy Markdown
Member Author

That's basically what the template does, aside from still include the NuGet package. As we've now moved over to Feliz.Bulma, I'm not sure what sense it makes to keep it.

@theimowski
Copy link
Copy Markdown
Member

yeah let's get it removed - noticed there's a recipe in docs that has inconsistent instructions between default and minimal: https://github.com/SAFE-Stack/docs/blob/master/docs/recipes/ui/add-fontawesome.md#3-code-snippet

@theimowski theimowski merged commit b91f054 into master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider removing Fable.FontAwesome?

3 participants