Add charset attribute to index.html#59
Merged
theimowski merged 2 commits intoSAFE-Stack:masterfrom Apr 19, 2018
Merged
Conversation
forki
requested changes
Apr 19, 2018
| <title>SAFE Template</title> | ||
| <!--#if (Fulma != "none") | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <meta charset="utf-8" name="viewport" content="width=device-width, initial-scale=1"> |
Member
There was a problem hiding this comment.
I think I did that recently in my code as well and html validation said it should be in a separate meta tag.
Contributor
Author
|
@forki addressed your remarks, also closed the elmish div correctly, according to https://validator.w3.org <div /> isn't valid either. |
Member
|
Thanks! released in 0.13.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to set the charset to utf8 in order to display
str “äöü“correctly, otherwise it fallbacks to ascii?! which looks quite ugly ;-)