Add support for Azure storage#77
Conversation
# Conflicts: # Content/arm-template.json
# Conflicts: # Content/arm-template.json
# Conflicts: # Content/src/Server/ServerSuave.fs
|
Should this always come with |
|
@theimowski I'm only speaking from personal experience here but I'm yet to work on an Azure-ready application that didn't use a Storage account in some way, shape or form.
We could make it configurable but even then I would rather have it turned on by default. |
|
fair enough, let me just test all server options and then add it |
| "prefix": "[concat('safe-', variables('environment'))]", | ||
| "appServicePlan": "[concat(variables('prefix'), '-web-host')]", | ||
| "web": "[concat(variables('prefix'), '-web')]", | ||
| "storage": "[concat('safe', variables('environment'), 'storage')]", |
There was a problem hiding this comment.
why don't use same naming convention (add dashes) as for other resources?
There was a problem hiding this comment.
Storage accounts have stricter requirements. No dashes, max of 24 characters and all lower case. In fact I'll probably add some more code into the template or script to enforce them all.
|
LGTM, thanks a lot! |
|
released in 0.19.0 |
This is probably as far as we should go in terms of a "generic" Azure SAFE implementation. It adds a Storage account to the ARM template, links it to the application through a connection string, adds the basic Azure Storage SDK to the Server project and creates an instance of the CloudStorageAccount.
Note: The local development environment (currently) only exists on Windows (and even that requires an installation). Nonetheless, this is still a good starting point for working with Azure Storage (provided we document it!).