Enable AppInsights only if Deploy = 'azure' on Suave server#81
Merged
isaacabraham merged 1 commit intoSAFE-Stack:masterfrom May 4, 2018
Zaid-Ajaj:patch-1
Merged
Enable AppInsights only if Deploy = 'azure' on Suave server#81isaacabraham merged 1 commit intoSAFE-Stack:masterfrom Zaid-Ajaj:patch-1
isaacabraham merged 1 commit intoSAFE-Stack:masterfrom
Zaid-Ajaj:patch-1
Conversation
Running `dotnet new SAFE --Server suave` adds app insights web part to main Suave web part which doesn't work because that only works if the `Deploy = "azure"`. This PR fixes it
Member
|
Argh! Good spot. Thanks for doing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
dotnet new SAFE --Server suaveadds app insights web part to main Suave web part which doesn't work because that only works if theDeploy = "azure". This PR fixes it.Also, a couple of names:
init => webApiandwebPart => webAppbecause "webApi is part of webApp" makes a bit more sense than "init is part of webPart"Tested locally, but messed up my branch so I just copy pasted it here ;)