Skip to content

[WIP] Update to latest Fulma#90

Merged
theimowski merged 2 commits intoSAFE-Stack:forki-patch-2from
MangelMaxime:update_fulma
May 11, 2018
Merged

[WIP] Update to latest Fulma#90
theimowski merged 2 commits intoSAFE-Stack:forki-patch-2from
MangelMaxime:update_fulma

Conversation

@MangelMaxime
Copy link
Copy Markdown

⚠️ I needed to remove the following line from paket.dependencies to make the template work.

//#if (Deploy == "azure")
  nuget Microsoft.Azure.Management.ResourceManager.Fluent 1.4.1
  github CompositionalIT/fshelpers src/FsHelpers/ArmHelper/ArmHelper.fs
//#endif

Otherwise, the template engine was complaining about srcOffset being invalid. Please test in your PR before publishing a new version.

@theimowski
Copy link
Copy Markdown
Member

Strange, which version of dotnet you're using?

/cc @forki - this is to be merged to original #89

@MangelMaxime
Copy link
Copy Markdown
Author

I am using dotnet 2.1.103

@MangelMaxime MangelMaxime changed the title Update to latest Fulma [WIP] Update to latest Fulma May 9, 2018
@MangelMaxime
Copy link
Copy Markdown
Author

Can you please wait like 1-2 days before merging this PR.

I am working on the latest version of Fulma which will support Bulma 0.7.1 (latest) and I am introducing a minor breaking change in the colunm system. Also, I am adding support for modifiers like text alignement etc.

So can make sense IMO to delay the template update to benefit of this changes.

The modifier addition is the last thing missing to have 100% of Bulma typed

@isaacabraham
Copy link
Copy Markdown
Member

Can I assume that that issue with the azure dependency is fixed? That can't be removed otherwise it'll break the deployment.

@MangelMaxime
Copy link
Copy Markdown
Author

@isaacabraham I didn't tested it since I create the PR but I don't why it would work now on my machine. I didn't change anything.

I will simply update the Fulma part (later in the day) and let you guys look at the issue with paket.dependencies if you can repro it or not.

@MangelMaxime
Copy link
Copy Markdown
Author

@theimowski This is ready to be merge into #89

I updated to latest version of Fulma and also removed all the usage of classes string in favor of Fulma API.

@theimowski theimowski merged commit d7eb771 into SAFE-Stack:forki-patch-2 May 11, 2018
@theimowski
Copy link
Copy Markdown
Member

awesome! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants