Skip to content

Fix loop issue #54 (multiprocess python >3.8 on OSX).#72

Merged
DrSoulain merged 3 commits intomasterfrom
fix_pool_loop
Nov 2, 2021
Merged

Fix loop issue #54 (multiprocess python >3.8 on OSX).#72
DrSoulain merged 3 commits intomasterfrom
fix_pool_loop

Conversation

@DrSoulain
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 2, 2021

Codecov Report

Merging #72 (8265540) into master (db66a37) will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   47.84%   47.88%   +0.04%     
==========================================
  Files          19       19              
  Lines        3618     3621       +3     
==========================================
+ Hits         1731     1734       +3     
  Misses       1887     1887              
Flag Coverage Δ
unittests 47.88% <80.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
amical/analysis/fitting.py 7.33% <80.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db66a37...8265540. Read the comment docs.

@neutrinoceros
Copy link
Copy Markdown
Collaborator

I checked this in #55 and it seems that it does not close #54. However I'm fine with merging this as is because it doesn't seem to create more problems.

"A" + str(j): np.nan for j in range(reducePoly + 1)
}, {"A" + str(j): np.nan for j in range(reducePoly + 1)}
tmp = (
{"A" + str(j): np.nan for j in range(reducePoly + 1)},
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's auto-black formatting no?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it coming up just now then ?

@DrSoulain DrSoulain merged commit f0be5f9 into master Nov 2, 2021
@neutrinoceros neutrinoceros deleted the fix_pool_loop branch November 2, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants