fix: netstandard2.0-safe finite check in WeatherHour#10
Merged
michaldengusiak merged 1 commit intoMay 27, 2026
Conversation
double.IsFinite is unavailable on netstandard2.0 (SAM.Weather's target), breaking the Release build. Replace with the equivalent IsNaN/IsInfinity guard introduced by 5f0f0a0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ZiolkowskiJakub
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5f0f0a0dintroduceddouble.IsFinite(...)inSAM.Weather/Classes/WeatherHour.cs, butSAM.Weathertargets netstandard2.0 wheredouble.IsFinitedoes not exist (added in netstandard2.1 / .NET Core 3.0). This breaks the Release build onsow/2026-Q2and every PR built against it.double.IsNaN(x) || double.IsInfinity(x).Test plan
dotnet build SAM/SAM.Weather/SAM.Weather.csproj -c Releasesucceeds (netstandard2.0)build (Release)+spdxgreen🤖 Generated with Claude Code