Pin System.Text.Json to 8.0.5 (+ small csproj cleanup)#3
Merged
Conversation
Aligns the repo with the SAM-BIM workspace-wide pin to the LTS-aligned System.Text.Json 8.0.5, replacing the previously pinned 10.0.8 preview.
In SAM.Units.Revit.csproj, also remove 16 empty <NoWarn /> elements scattered across the per-Revit-year PropertyGroups. They suppress nothing (no codes listed) and only add noise to the file.
ZiolkowskiJakub
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
System.Text.Jsonto 8.0.5 across all .csproj files in this repo, replacing 10.0.8. Part of a workspace-wide alignment to the LTS-aligned 8.x line (10.x is .NET-10 preview track and inappropriate for libraries still targeting netstandard2.0 / net8.0-windows).<NoWarn />elements inSAM_Revit/SAM.Units.Revit/SAM.Units.Revit.csproj. They suppress nothing (no warning codes listed) and only add noise.Test plan
<NoWarn />was already empty so nothing was actually being suppressed)🤖 Generated with Claude Code