Pin System.Text.Json to 8.0.5#2
Conversation
Aligns the repo with the SAM-BIM workspace-wide pin to the LTS-aligned System.Text.Json 8.0.5, replacing the previously pinned 10.0.8 preview.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cbdb84339
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
| <UseWindowsForms>true</UseWindowsForms> | ||
| <UseWPF>true</UseWPF> | ||
| <Deterministic>false</Deterministic> |
There was a problem hiding this comment.
This change introduces <Deterministic>false</Deterministic>, which disables deterministic compiler output for this project (and similarly in the Architectural/Weather projects) even though the commit is intended to only pin System.Text.Json. Turning determinism off makes identical source builds produce different binaries, which hurts reproducibility, artifact verification, and cache hit rates in CI; because this is unrelated to the package-version change and only applied to a subset of projects, it looks like an unintended regression.
Useful? React with 👍 / 👎.
2 participants
Summary
System.Text.Jsonto 8.0.5 in all .csproj files in this repo, replacing 10.0.8.Test plan
🤖 Generated with Claude Code