security implementations, example webapp was included an some bugs was fixed.#10
Merged
pitbulk merged 2 commits intoSAML-Toolkits:masterfrom Jul 30, 2014
iguanajazz:master
Merged
security implementations, example webapp was included an some bugs was fixed.#10pitbulk merged 2 commits intoSAML-Toolkits:masterfrom iguanajazz:master
pitbulk merged 2 commits intoSAML-Toolkits:masterfrom
iguanajazz:master
Conversation
pitbulk
added a commit
that referenced
this pull request
Jul 30, 2014
security implementations, example webapp was included an some bugs was fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On AuthRequest class:
getRidOfCRLF method was removed and functionality was implemented on encodeSAMLRequest method.
On Response class:
Implemented checks required on isValid method:
ID in the response must exists.
The number of Assertion Nodes must be exactly one.
Conditions may be review and validates Review, Review Destination and Check SubjectConfirmation.
And some bugs was fixed.
On index.jsp and consume.jsp dependency to org.apache.log4j.Logger was removed.
In general:
Sample web app structure was added included com-folder files inside java web application.
pom.xml was configured to handle dependencies and jetty plugin was configured to test jsp files.
Readme was added.