Changed code to use specific XPathFactoryImpl#192
Changed code to use specific XPathFactoryImpl#192pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
Conversation
This changes the XPathFactory call to use a specific XPathFactoryImpl to avoid issues where an environment may be using a default implementation that's incompatible with the code (such as using an outdated Saxon parser). This change attempts to use the default Java implementation, but if that is unavailable will fallback to try to load the default. This will also help to ensure the XML is always parsed in a consistent manor, since everyone should be using the same XPathFactoryImpl.
|
This change seem to have some side-effects when running OpenSaml under Karaf-container. fails under JDK (1.8.101) with:
Likely due to weird classloading that Karaf likes to do. I don't see a way to avoid it, short of patching the Util class or bumping JDK-version.
Any workaround suggestions? |
This changes the XPathFactory call to use a specific XPathFactoryImpl to avoid issues where an environment may be using a default implementation that's incompatible with the code (such as using an outdated Saxon parser). This change attempts to use the default Java implementation, but if that is unavailable will fallback to try to load the default.
This will also help to ensure the XML is always parsed in a consistent manor, since everyone should be using the same XPathFactoryImpl.
This should resolve Issue #191.