Add NVD checker to travis build#224
Merged
pitbulk merged 3 commits intoSAML-Toolkits:masterfrom Mar 11, 2019
Merged
Conversation
Checks fail if any found vulnerability's severity is 7 (high) or more. CVSS Severity ratings are explained here https://www.first.org/cvss/specification-document
A ServerSocketReceiver related vulnerability was fixed in version 1.2.0. Although OneLogin does not use this feature it does not hurt to update the dependency.
Contributor
|
Thanks for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes to introduce NVD checker.
Related to issue #223
I included an empty suppressions file for future use.
It is pretty easy to edit. A guide is here https://jeremylong.github.io/DependencyCheck/general/suppression.html
Also correct suppression tags can be copy pasted from the report the tool generates.
The false positive came from an old logback version that has a ServerSocketReceiver related vulnerability. I don't think OneLogin uses that feature, but I thought it would be best to just update the dependency.