add status for logout response#244
Closed
harunhonour wants to merge 1 commit intoSAML-Toolkits:masterfrom
harunhonour:add-status-logout-response
Closed
add status for logout response#244harunhonour wants to merge 1 commit intoSAML-Toolkits:masterfrom harunhonour:add-status-logout-response
harunhonour wants to merge 1 commit intoSAML-Toolkits:masterfrom
harunhonour:add-status-logout-response
Conversation
pitbulk
reviewed
Oct 23, 2019
| * InResponseTo attribute value to bet set at the Logout Response. | ||
| */ | ||
| public void build(String inResponseTo) { | ||
| public void build(String inResponseTo, String status) { |
Contributor
There was a problem hiding this comment.
Can you leave the public void build(String inResponseTo) method as well?
public void build(String inResponseTo) {
build(inResponseTo, Constants.STATUS_SUCCESS)
}
And then leave build() as it was
public void build() {
build(null);
}
pitbulk
reviewed
Oct 23, 2019
| * InResponseTo attribute value to bet set at the Logout Response. | ||
| */ | ||
| public void build(String inResponseTo) { | ||
| public void build(String inResponseTo, String status) { |
Contributor
There was a problem hiding this comment.
Can you rename the status param to statusCode ?
Contributor
|
I added some comments. Also the PR lacks test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When returning Logout Response, there is no way to set the status. This PR adds the status field.