fix signature validation issue#276
Merged
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom Sep 2, 2020
chenrui333:patch-1
Merged
fix signature validation issue#276pitbulk merged 1 commit intoSAML-Toolkits:masterfrom chenrui333:patch-1
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
chenrui333:patch-1
Conversation
chenrui333
commented
Sep 2, 2020
| byte[] dataBytes = x509cert.getEncoded(); | ||
| if (alg == null || alg.isEmpty() || alg.equals("SHA-1")|| alg.equals("sha1")) { | ||
| fingerprint = DigestUtils.sha1Hex(dataBytes); | ||
| } else if (alg.equals("SHA-256") || alg .equals("sha256")) { |
Contributor
Author
There was a problem hiding this comment.
@pitbulk I have already tested in my local, that this does fix for my fingerprint validation check.
Contributor
Author
|
Thanks @pitbulk! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #275