Merged
Conversation
Contributor
|
🐠 Keep adding validations! we want this toolkit as secure as the php/python/ruby toolkits! gogogo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
Add security to avoid user impersonation / authentication bypass
Deploy Notes
Configure files:
sample/src/main/webapp/index.jsp
set AssertionConsumerServiceUrl if is necessary
set Issuer if is necessary
set IdpSsoTargetUrl with your OneLogin SAML app information
sample/src/main/webapp/consume.jsp
set certificateS with your app X.509 Certificate
Steps to Test or Reproduce
mvn install
cd sample
mvn jetty:run