Hack to get around OneLogin not returning an audience#33
Merged
iguanajazz merged 1 commit intoSAML-Toolkits:masterfrom Jul 1, 2015
Merged
Hack to get around OneLogin not returning an audience#33iguanajazz merged 1 commit intoSAML-Toolkits:masterfrom
iguanajazz merged 1 commit intoSAML-Toolkits:masterfrom
Conversation
Contributor
|
Oh, I see, You are right! |
iguanajazz
added a commit
that referenced
this pull request
Jul 1, 2015
Hack to get around OneLogin not returning an audience
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I love your toolkit and is one of the primary reasons why I'm choosing OneLogin over Okta. Your toolkit is so straightforward and easy to use whereas Okta just suggested using opensaml and I frankly just don't have the time or the patience to deal with that library.
Anyway, funny enough, I used your toolkit with immediate (and very easy) success with Okta. HOWEVER, when using it with OneLogin the response is never valid because the audience can not be located in the assertion. As a quick hack to get around it so I could finish my evaluation of both OneLogin and Okta I did the changes included in this pull request. Perhaps I configured my Test SAML connector wrong in OneLogin - I don't know. BUT, I have to say, it is hilarious that your toolkit worked out of the box with Okta (I did nothing special) but not with OneLogin...