getLocalName causes NPE if xml has \n#36
Merged
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom Nov 18, 2015
tebruno99:patch-1
Merged
getLocalName causes NPE if xml has \n#36pitbulk merged 1 commit intoSAML-Toolkits:masterfrom tebruno99:patch-1
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
tebruno99:patch-1
Conversation
getLocalName causes NullPointerExceptions if the XML is fancy formatted with new lines. This is because getLocalName() will always return null if the node type is not Element or Attribute. The libraries treat new lines in SubjectConfirmation as child nodes which causes getLocalName() to be null.
pitbulk
added a commit
that referenced
this pull request
Nov 18, 2015
getLocalName causes NPE if xml has \n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getLocalName causes NullPointerExceptions if the XML is fancy formatted with new lines. This is because getLocalName() will always return null if the node type is not Element or Attribute. The libraries treat new lines in SubjectConfirmation as child nodes which causes getLocalName() to be null.