Use java.time instead of joda-time#374
Merged
gkhaburzaniya-onelogin merged 2 commits intoSAML-Toolkits:exclude-joda-timefrom Nov 18, 2022
Merged
Use java.time instead of joda-time#374gkhaburzaniya-onelogin merged 2 commits intoSAML-Toolkits:exclude-joda-timefrom
gkhaburzaniya-onelogin merged 2 commits intoSAML-Toolkits:exclude-joda-timefrom
Conversation
maruTA-bis5
force-pushed
the
201-exclude-joda-time
branch
from
17ac8c4 to
591c358
Compare
Contributor
Author
|
I'm sorry for lack of activity. I've rebased onto the latest master and AFAIK, It can be fixed by #390. Thanks. |
haavar
reviewed
Sep 21, 2022
| if (sessionExpiration != null) { | ||
| sessionExpiration = sessionExpiration.plus(Constants.ALOWED_CLOCK_DRIFT * 1000); | ||
| if (sessionExpiration.isEqualNow() || sessionExpiration.isBeforeNow()) { | ||
| sessionExpiration = ChronoUnit.SECONDS.addTo(sessionExpiration, Constants.ALOWED_CLOCK_DRIFT); |
There was a problem hiding this comment.
Seem like this pattern repeat a lot. Think it would be good to make isOnOrAfterNow(Instant) and isBeforeNow(Instant) methods to the util class. The methods would account for the allowed clock drift.
It would make the code more readable.
gkhaburzaniya-onelogin
changed the base branch from
master
to
exclude-joda-time
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #201