#60: allow retrieving the generated request ids#61
Merged
pitbulk merged 3 commits intoSAML-Toolkits:v2.0.0from Aug 30, 2016
Merged
#60: allow retrieving the generated request ids#61pitbulk merged 3 commits intoSAML-Toolkits:v2.0.0from
pitbulk merged 3 commits intoSAML-Toolkits:v2.0.0from
Conversation
- Auth now has getLastLoginRequestId/getLastLogoutRequestId methods that allow retrieving the id of the generated AuthnRequest/LogoutRequest message to be used in response validation
| return UNIQUE_ID_PREFIX + uniqueIdSha1; | ||
| } catch (Exception e) { | ||
| LOGGER.error("Error executing generateUniqueID: " + e.getMessage(), e); | ||
| throw new RuntimeException("Error executing generateUniqueID: " + e.getMessage(), e); |
Contributor
Author
There was a problem hiding this comment.
This avoids returning a non-unique, empty id when generating the id fails.
|
|
||
| /** | ||
| * The id of the last AuthnRequest generated | ||
| */ |
Contributor
There was a problem hiding this comment.
Do you think is necessary to use lastLoginRequestId lastLogoutRequestId rather than just _lastRequestID?
When you are using the auth class, you already control what methods do you call, so I think we can manage all in 1 unique parameter.
Contributor
Author
There was a problem hiding this comment.
Sure, I'll change this.
Contributor
|
@miszobi thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
that allow retrieving the id of the generated AuthnRequest/LogoutRequest
message to be used in response validation