Skip to content

Adds UTF-8 encoding when converting bytes to string#92

Merged
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
rembjo0:topic-encoding
Feb 2, 2017
Merged

Adds UTF-8 encoding when converting bytes to string#92
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
rembjo0:topic-encoding

Conversation

@rembjo0
Copy link
Copy Markdown

@rembjo0 rembjo0 commented Feb 2, 2017

XML validation fails when the JVM does not use UTF-8 as the default
encoding. Added UTF-8 encoding in byte to string conversions in:

  • SamlResponse - after base64decode SAMLResponse
  • Util.convertDocumentToString()

XML validation fails when the JVM does not use UTF-8 as the default
encoding. Added UTF-8 encoding in byte to string conversion in:
  * SamlResponse - after base64decode SAMLResponse
  * Util.convertDocumentToString()
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 95.947% when pulling cb24c1b on rembjo0:topic-encoding into 26def30 on onelogin:master.

@pitbulk
Copy link
Copy Markdown
Contributor

pitbulk commented Feb 2, 2017

Thanks for solving that.

@pitbulk pitbulk merged commit 560d41d into SAML-Toolkits:master Feb 2, 2017
@rembjo0
Copy link
Copy Markdown
Author

rembjo0 commented Feb 4, 2017

Thanks for the quick response and accepting.
There are two more pull requests comming with the last details we need to get an ADFS 2.0 integration up and running using a plain vanilla OneLogin build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants