Fix example.py and protect example.cfg from accidental commits to a public repository#10
Closed
Version2beta wants to merge 2 commits intoSAML-Toolkits:masterfrom
Version2beta:master
Closed
Fix example.py and protect example.cfg from accidental commits to a public repository#10Version2beta wants to merge 2 commits intoSAML-Toolkits:masterfrom Version2beta:master
Version2beta wants to merge 2 commits intoSAML-Toolkits:masterfrom
Version2beta:master
Conversation
Author
|
The example.py program calls a class method called AuthnRequest.create, but the current code provides a class called AuthRequest. The attached pull request changes the class name to AuthRequest and allows the code to run without an exception. |
Author
|
Ooops, sorry didn't mean to close the pull request! Reopened. |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In working with the provided example, I realized that potentially sensitive information (even if it's only the address of a SAML provider) may inadvertently be committed to a public repository if the user edits example.cfg directly. This pull request moves the provided example.cfg to example.cfg.dist and instructs the user to copy the file and then edit. Also, example.cfg and likely certificate files are now blocked in .gitignore.