Skip to content

Docs for OS X installation of libsecxml1#138

Merged
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
AvnerCohen:osx_install
May 24, 2016
Merged

Docs for OS X installation of libsecxml1#138
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
AvnerCohen:osx_install

Conversation

@AvnerCohen
Copy link
Copy Markdown
Contributor

No description provided.

@AvnerCohen AvnerCohen changed the title Docs for OSx instlltion of libsecxml1 Docs for OS X installtion of libsecxml1 May 18, 2016
@AvnerCohen AvnerCohen changed the title Docs for OS X installtion of libsecxml1 Docs for OS X installation of libsecxml1 May 18, 2016
@pitbulk
Copy link
Copy Markdown
Contributor

pitbulk commented May 18, 2016

libsecxml1 dependence was already mentioned
https://github.com/onelogin/python-saml/blob/master/README.md#dependences

And I don't think is necessary to mention the brew command...

@AvnerCohen
Copy link
Copy Markdown
Contributor Author

Could be, this means an OS X user of the library needs to spend some time finding that out from this list of dependencies? Do you see any harm in providing the extra information?
I for one spent some time on that and to me, as an OS X user, this could of been very beneficial.

@pitbulk
Copy link
Copy Markdown
Contributor

pitbulk commented May 18, 2016

Ok, but I don't think libsecxml1 is the unique dependence on OSX, what about dm.xmlsec.binding?

If you want to provide full documentation about how to install python-saml on OSX I can host that specific info at the repo, but need to be complete.

@AvnerCohen
Copy link
Copy Markdown
Contributor Author

This seems to work out of the box with the combination of the python lib in the setup.py and the dependencies of the brew formula:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/libxmlsec1.rb

To me, once running the formula, it worked. I might be missing something though, I have little knowledge of the ins of SAML.

@pitbulk
Copy link
Copy Markdown
Contributor

pitbulk commented May 18, 2016

In order to check that all is installed as expected, try to deploy any demo and let me know if the SAML flow. Or install the dev dependencies

pip install -e ".[test]"

and execute the tests:

python setup.py test

@AvnerCohen
Copy link
Copy Markdown
Contributor Author

Good idea, this seems to work just fine.
Here is the full log of the install + tests for reference:

https://gist.github.com/AvnerCohen/d334c7680458e79a7c9906175527aaea

@pitbulk pitbulk merged commit 3cf2203 into SAML-Toolkits:master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants