Fix creation of metadata with no SLS, when using settings.get_sp_metadata()#66
Merged
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom May 8, 2015
Merged
Conversation
pitbulk
added a commit
that referenced
this pull request
May 8, 2015
Fix creation of metadata with no SLS, when using settings.get_sp_metadata()
6 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if one wishes to generate SAML metadata using:
an error will occur if your settings do not specify a
singleLogoutServiceURL in the config. This is meant to be optional, but the settings parser always adds an emptysingleLogoutServicedict to the settings dict, which gets interpreted by other parts of the code as meaning thatsingleLogoutServiceshould be used. The fix checks for the presence ofsettings['singleLogoutService']['url'], which should only be present when the user actually wants to use asingleLogoutService.This is a contribution from edX, developed by OpenCraft as part of bringing integrated SAML support to the edX platform, via a new python-social-auth SAML backend.