Allow metadata signing with SP key specified as config value, not file#69
Merged
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom Jun 24, 2015
Merged
Conversation
Contributor
|
Thanks, will review and test it and merge soon. |
6 tasks
Contributor
Author
|
@pitbulk Do you think you'll be able to review this and the other open PRs soon? Please let me know if there's any additional info or examples of use that I could provide. |
14 tasks
pitbulk
added a commit
that referenced
this pull request
Jun 24, 2015
Allow metadata signing with SP key specified as config value, not file
Contributor
|
New version 2.1.3 released (also available on pypi ) |
Contributor
Author
|
Awesome, thanks! I have opened PRs for python-social-auth and edx-platform to use the new release rather than my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple fix: If python-saml is configured to sign metadata using the same key that it uses as an SP, it will only work if the key was present as a file on disk. If the SP key is specified as a string value directly in settings, the metadata signing gives an error. This fix makes it work either way.
This is a contribution from edX, developed by OpenCraft as part of bringing integrated SAML support to the edX platform, via a new python-social-auth SAML backend.