IdP metadata parser: fix singleSignOnService processing#16
Merged
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom Apr 28, 2016
Merged
IdP metadata parser: fix singleSignOnService processing#16pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a typo in the new idp_metadata_parser module: it consumes the
singleLogoutServiceXML tag for populatingidp_sso_url, instead of thesingleSignOnServicetag. This PR fixes the typo and adjusts the tests.Parser tests pass:
Note that the test data also specifies
SingleLogoutServices:They are part of the
SPSSODescriptortag which is not looked into by the IdP parser. So, theexpected_datain the tests does not contain any SLSs.That's the data the IdP parser currently (with the change from this PR) creates when parsing https://www.testshib.org/metadata/testshib-providers.xml:
@pitbulk I hope this is now as expected. Please review, thanks!