Load idp certs from file#178
Merged
pitbulk merged 4 commits intoSAML-Toolkits:masterfrom Jan 15, 2020
Merged
Conversation
Contributor
|
There are places in the code that uses idp_data['x509cert'] instead of the method get_idp_cert, for example:
Those should be updated to use get_idp_cert |
Author
|
Thanks. Updated. Also updated some of the existing tests by making use of a new settings file which doesn't have a custom-base-path, so the idp.crt is not found in the path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very trivial. But loading idp public certificate just like the sp certificates.