fix: treat single-label-domains as valid#217
Closed
alexdao3 wants to merge 1 commit intoSAML-Toolkits:masterfrom
Closed
fix: treat single-label-domains as valid#217alexdao3 wants to merge 1 commit intoSAML-Toolkits:masterfrom
alexdao3 wants to merge 1 commit intoSAML-Toolkits:masterfrom
Conversation
In Docker/Kubernetes/testing, it's common to have a service/hostname without a domain i.e. http://saml-service:5555. Some places refer to these as single-label-domains[1] Previously validate_url only allowed `localhost` and considered other hostnames invalid if they didn't contain a domain suffix. This relaxes the restriction to allow for single-label-domains [1] https://docs.microsoft.com/en-us/troubleshoot/windows-server/ networking/single-label-domains-support-policy
Contributor
|
Sorry for the delay, I'm not able to find any reference on the SAML standard about single-label-domains. That is a common request from the Docker/Kubernetes world, I'm open to allow them, but by a new setting. @alexdao3 are you able to modify your PR to include a new advanced setting: by default set to False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
In Docker/Kubernetes/testing, it's common to have a service/hostname
without a domain i.e. http://saml-service:5555. Some places refer to
these as single-label-domains[1]
Previously validate_url only allowed
localhostand considered otherhostnames invalid if they didn't contain a domain suffix. This relaxes
the restriction to allow for single-label-domains
[1] https://docs.microsoft.com/en-us/troubleshoot/windows-server/networking/single-label-domains-support-policy