Fixes Windows specific Unix date formatting bug#23
Merged
pitbulk merged 2 commits intoSAML-Toolkits:masterfrom May 24, 2016
Merged
Fixes Windows specific Unix date formatting bug#23pitbulk merged 2 commits intoSAML-Toolkits:masterfrom
pitbulk merged 2 commits intoSAML-Toolkits:masterfrom
Conversation
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| """ | |||
| from datetime import datetime | |||
Contributor
There was a problem hiding this comment.
Can you remove that import?, not required anymore
Contributor
|
@kipparker Please remove the unnecessary import so I will be able to merge the PR |
Contributor
Author
|
@pitbulk thanks, removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting Unix time with strftime("%s") will only work on POSIX platforms, so not on Windows. time() is fine for both.