Skip to content

Preserve xmlns:xs namespace when signing and serializing responses#80

Merged
pitbulk merged 4 commits intoSAML-Toolkits:masterfrom
cjduffett:bugfix/add-sign-xmlns-xs-patch
Dec 11, 2017
Merged

Preserve xmlns:xs namespace when signing and serializing responses#80
pitbulk merged 4 commits intoSAML-Toolkits:masterfrom
cjduffett:bugfix/add-sign-xmlns-xs-patch

Conversation

@cjduffett
Copy link
Copy Markdown
Contributor

Fix for: #76

This PR overrides the OneLogin_Saml2_XML static method cleanup_namspaces, which is directly invoking etree.cleanup_namespaces. I added a whitelist of namespaces that should not be cleaned from an element before serialization into XML. This preserves the xmlns:xs namespace that's specifically needed to validate the schema of a SAML Response's attributes.

I also added some additional namespace prefix constants (now grouped with the other namespace constants) in OneLogin_Saml2_Constants.

@cjduffett
Copy link
Copy Markdown
Contributor Author

@pitbulk For review please.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 17, 2017

Coverage Status

Coverage decreased (-0.02%) to 96.004% when pulling 0e7b731 on cjduffett:bugfix/add-sign-xmlns-xs-patch into 6505e5c on onelogin:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 17, 2017

Coverage Status

Coverage decreased (-0.02%) to 96.004% when pulling 0003e7c on cjduffett:bugfix/add-sign-xmlns-xs-patch into 6505e5c on onelogin:master.

@patricksanders
Copy link
Copy Markdown

Any word on this PR? We're having to work around it right now, would be nice to have this merged.

@fgao22
Copy link
Copy Markdown

fgao22 commented Dec 11, 2017

Same here. Anything we can do to get this PR passed and merged?

@pitbulk pitbulk merged commit baa12f1 into SAML-Toolkits:master Dec 11, 2017
@cjduffett cjduffett deleted the bugfix/add-sign-xmlns-xs-patch branch December 11, 2017 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants