Skip to content

Updated invalid audience error, and tests to match.#441

Merged
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
capybaras:fix-invalid-audience-error
Apr 23, 2018
Merged

Updated invalid audience error, and tests to match.#441
pitbulk merged 1 commit intoSAML-Toolkits:masterfrom
capybaras:fix-invalid-audience-error

Conversation

@capybaras
Copy link
Copy Markdown
Contributor

@capybaras capybaras commented Feb 13, 2018

Fixes:

#440

Example

Given a SAML Assertion with the Audience value of "A", and an SP configuration requiring an audience of "B"

Old message:

"B is not a valid audience for this Response - Valid audiences: A"

or (for multiple)

"B is not a valid audience for this Response - Valid audiences: A1, A2, A3"

New message:

Invalid Audience. The audience A, did not match the expected audience B

or (for multiple)

Invalided Audiences. The audiences A1, A2, A3 did not match the expected audience B

@xlgmokha
Copy link
Copy Markdown

I like the new error messaging better. The old error message confused me on several different occasions.

@pitbulk pitbulk merged commit 25be1b9 into SAML-Toolkits:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants