-
Notifications
You must be signed in to change notification settings - Fork 13
Instructions to solve the problem of building up the project with Maven #28
Conversation
…th Maven is illustrated
GezimSejdiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mohammad,
many thanks for your PR and resolving the issue between jets3t 0.9.4 compatibility version
Please, read my comments below. Will merge the PR when they are done!
Best regards,
README.md
Outdated
| ### [sansa-examples-flink](https://github.com/SANSA-Stack/SANSA-Examples/tree/master/sansa-examples-flink) | ||
| Contains the SANSA Examples for [Apache Flink](http://flink.apache.org/). | ||
|
|
||
| ## Not able to build the project with maven then read this section: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove the whole section above. We want to keep the repo clean from such instructions, most of the developers who start using SANSA are familiar with the maven installation instructions and this could be relevant for your environment settings only. In the case of the students attending our lab, we also provide some basic instructions on our Big Data lab here: https://github.com/SmartDataAnalytics/MA-INF-4223-DBDA-Lab/blob/master/labs/WorkSheet-1.md and maybe this is relevant to be added there, so feel free to suggest changes on the worksheet:).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Gezim,
Thanks for reviewing the PR. I see. Then I removed and cleaned README.md :)
Warmest regards,
Mohammad
| <scope>import</scope> | ||
| </dependency> | ||
|
|
||
| <!-- Commons-codec dependency: solve the issue of making clean install--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment!
|
|
||
| <!-- Commons-codec dependency: solve the issue of making clean install--> | ||
| <dependency> | ||
| <groupId>commons-codec</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for adding this dependency and resolving the issue between jets3t 0.9.4 compatibility version.
this pull request solve the compilation and building problems with the project:
Warmest regards,
Mohammadali