Updated PHP SDK #12
Updated PHP SDK #12
Conversation
…o file analysis (depreciated)
src/apis/Request/Request.php
Outdated
| "language" => $language, | ||
| "conversation_token" => $conversation_token, | ||
| "memory" => $memory | ||
| "memory" => $memory, |
There was a problem hiding this comment.
Could you set the memory field only if it was given as argument please ? It may replace the existing memory with an empty one otherwise
There was a problem hiding this comment.
@dbousque No because memory is set to NULL by default
There was a problem hiding this comment.
It is not correct to pass a null memory and expect nothing to happen :) According to the bot-builder API, it could very well reset the memory, it is not semantically wrong, so let's just make things easier. Someone might think it was an error to set it to null instead of {} for example, and correcting that, he would break everything.
There was a problem hiding this comment.
Usage of these parameter is described in the documentation (Wiki)
Regarding the BotBuilderAPI project code, the memory parameter is taken in account only if its value is "true" (so, not equal to null). This code works
There was a problem hiding this comment.
What do you mean by "the memory parameter is taken in account only if its value is 'true'" ? The memory argument is expected to be a json object.
|
good for me |
3 participants
Added optional parameters : memory and log_level, to the dialog endpoint
Added a proxy option
Removed audio endpoint