This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Refactor namespace #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks you very much for this awesome work! This pull request introduces breaking changes, so i'll need to merge and publish under version 2.0.0. Cheers, |
Contributor
Author
|
No problem at all, feel free to do whatever you need with the rewrote code. It did the work mostly for correcting the namespaces (in order to integrate it with my app) but had to rewrite some other parts for the code to be consistent. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting rewriting the lib with some good PHP practices. Feel free to comment.