Update CDS Services to 1.29.0#175
Merged
beckermarc merged 2 commits intomainfrom Nov 4, 2022
Merged
Conversation
Contributor
beckermarc
commented
Nov 3, 2022
beckermarc
commented
- Use H2 v2 with new h2 dialect provided by CDS Compiler
- Use new name java instead of old java-cf for build tasks
- Update dependencies
- Use H2 v2 with new h2 dialect provided by CDS Compiler - Use new name java instead of old java-cf for build tasks - Update dependencies
| "tasks": [ | ||
| { | ||
| "for": "java-cf" | ||
| "for": "java" |
Contributor
There was a problem hiding this comment.
are you sure about this? We still seem to run classic mtx in the bookshop
Contributor
Author
There was a problem hiding this comment.
I think this change is independent of streamlined or classic MTX, but we can also keep it back if you like.
Contributor
Author
There was a problem hiding this comment.
I'd suggest to go for it. @mofterdinger also proposed a similar change to the projects that we generate in the cds-services archetype.
Contributor
There was a problem hiding this comment.
indeed java-cf and java point to the same implementation. java-cf should be replaced.
BraunMatthias
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.