Upated mta.yamls#183
Merged
BraunMatthias merged 3 commits intomainfrom Dec 9, 2022
Merged
Conversation
BraunMatthias
approved these changes
Dec 9, 2022
beckermarc
reviewed
Dec 9, 2022
| "scripts": { | ||
| "start": "node node_modules/@sap/hdi-deploy --exit" | ||
| "start": "node node_modules/@sap/hdi-deploy/deploy.js", | ||
| "build": "npm i && npx -p @sap/cds-dk@^6 cds build .. --for hana --production" |
Contributor
There was a problem hiding this comment.
Little unfortunate that we hide another @sap/cds-dk version here again. This makes it not really transparent in ensuring that Java app and DB module are built with the same @sap/cds-dk version..
Member
Author
There was a problem hiding this comment.
Yes, you are right, but that's the current situation. Maybe we have to remove the approach to set the cds-dk version in pom.xml and maintain it globally in a package.json that we can share the same cds-dk version for all modules (db, srv, ....)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
align mta-single-tenant.yaml with command: cds add mta