Skip to content

update approuter version#190

Merged
beckermarc merged 2 commits intoSAP-samples:mainfrom
sidakphull:approuter-version
Jan 10, 2023
Merged

update approuter version#190
beckermarc merged 2 commits intoSAP-samples:mainfrom
sidakphull:approuter-version

Conversation

@sidakphull
Copy link
Copy Markdown
Contributor

@sap/appruter:12.0.1 has some changes which make deploying approuter on Kyma very easy.

It'd be great if this change is also merged with the streamlined-mtx branch.

@beckermarc
Copy link
Copy Markdown
Contributor

Hi @sidakphull, thanks for opening this PR. Can you please provide a pointer to the release notes of approuter version 12. I'd be interested in reading about the changes :)

@beckermarc
Copy link
Copy Markdown
Contributor

I only found release notes internally. I noticed that meanwhile also version 13 is available. Does it make sense to update to it directly?

Comment thread app/package.json Outdated
Co-authored-by: Marc Becker <marc.becker@sap.com>
@sidakphull
Copy link
Copy Markdown
Contributor Author

Hi @sidakphull, thanks for opening this PR. Can you please provide a pointer to the release notes of approuter version 12. I'd be interested in reading about the changes :)

Hi Marc, I sent you a message on Teams with the internal links. Let me know if something more is required.

@beckermarc beckermarc self-requested a review January 10, 2023 07:52
Copy link
Copy Markdown
Contributor

@beckermarc beckermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer version of approuter include an updated xsenv, which better supports service bindings on Kyma / K8s.

@beckermarc beckermarc merged commit 3d9cc3d into SAP-samples:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants