Skip to content

Switch to Java 17 as default#195

Merged
vmikhailenko merged 4 commits intomainfrom
java-17-main
Jan 31, 2023
Merged

Switch to Java 17 as default#195
vmikhailenko merged 4 commits intomainfrom
java-17-main

Conversation

@vmikhailenko
Copy link
Copy Markdown
Contributor

@vmikhailenko vmikhailenko commented Jan 31, 2023

Switches sample to Java 17 as default.

Additional space added to the Java backend to accommodate downloaded JRE. Sidecar is also grew bigger.

@vmikhailenko vmikhailenko marked this pull request as ready for review January 31, 2023 10:56
Comment thread pom.xml
Comment thread values.yaml Outdated
@vmikhailenko vmikhailenko merged commit c4a6d99 into main Jan 31, 2023
@vmikhailenko vmikhailenko deleted the java-17-main branch January 31, 2023 14:02
@helencorrigan
Copy link
Copy Markdown

Hello @vmikhailenko
Could you please explain why this upgrade to java 17 was done?

@beckermarc
Copy link
Copy Markdown
Contributor

beckermarc commented Feb 3, 2023

As of CAP Java 1.31.0, which was released end of January Java 17 is the recommended Java version. This is documented in our release notes: https://pages.github.tools.sap/cap/docs/releases/jan23#jdk-17-support. To reflect this also in our sample application, we made this change.

@helencorrigan
Copy link
Copy Markdown

@beckermarc thank you for this feedback.

@helencorrigan
Copy link
Copy Markdown

@beckermarc @vmikhailenko

Via the community the following issue has been reported : Error in step 6 of CAP tutorial Reuse a CAP Java Service | SAP Community

Does the SBAS environment need to upgrade?

@beckermarc
Copy link
Copy Markdown
Contributor

Does the SBAS environment need to upgrade?

Yes I think Java 17 should be available in BAS and easily usable. It might also make sense to make it the default.

@helencorrigan
Copy link
Copy Markdown

helencorrigan commented Feb 3, 2023

@beckermarc
currently we use this SBAS env : https://sap-ux-stage.cry10cf.int.applicationstudio.cloud.sap/index.html
& it has 11, therefore now when we use this repo in SBAS, we get the error reported in the community.

Do you know when the SBAS will be upgraded to 17?
did SBAS confirm they will install version 17?

@beckermarc
Copy link
Copy Markdown
Contributor

As said in our internal chat, I'd recommend to get in touch with BAS colleagues. For the time being you can also simply change the jdk.version property in pom.xml to 11 in your local clone. Then the project will run with Java 11. So far no Java 17 specific features are used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants