Draft
Conversation
davidhunglam
changed the title
Contributor
Author
|
PR only to review the changes, we'll keep the |
StefanHenke
reviewed
Oct 18, 2024
Contributor
There was a problem hiding this comment.
In other branches like for messaging, we kept the mta-multi-tenant.yaml and added a separate one mta-multi-tenant-messaging.yaml. Should we stick to that pattern?
Contributor
There was a problem hiding this comment.
Dedicated mta files would be the preferred solution to demonstrate different flavours. I'd vote for mta-multi-tenant-ias-ams.yaml. We should also find a way to make this as a base for integ tests.
StefanHenke
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR only to review the changes, we'll keep the
identitybranch. It's not supposed to be merged tomain!