Skip to content

Conversation

@etimr
Copy link
Contributor

@etimr etimr commented Mar 14, 2025

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Mar 14, 2025

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Mar 14, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@etimr etimr requested a review from eugene-andreev March 14, 2025 14:23
/**
* Example of a custom handler for nextSiblingAction
*/
@Profile("hybrid")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in other areas we are using cloud

Label : '{i18n>Contents}',
Target : 'contents/@UI.PresentationVariant'
Target : 'contents/@UI.PresentationVariant',
![@UI.Hidden] : contentsHidden
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we can also refer to a Singleton entity here.

public class SetHiddenHandler implements EventHandler {

@After(entity = Books_.CDS_NAME)
void removeUIHidden(EventContext context){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should be able to use Result in the method signature.

@beckermarc
Copy link
Contributor

beckermarc commented Mar 26, 2025

Replaced by #460 which however still runs into a UI bug. Did you observe the same UI issues with this approach? Edit: Bug seems to be avoided by avoiding $Not in the expression.

@beckermarc beckermarc closed this Mar 26, 2025
@beckermarc beckermarc deleted the d070615-dynamic-ui-hidden branch March 26, 2025 10:45
beckermarc added a commit that referenced this pull request Mar 27, 2025
Replaces #456
by using a singleton, instead of adding a property to books.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants