docs(km): apply KM fixes and expand abapcloud destination guide#139
Merged
docs(km): apply KM fixes and expand abapcloud destination guide#139
Conversation
- Fix markdown lint issues: multiple H1s, bare code fence, trailing space, missing blank lines around list and code fence - Apply KM rules: H4 headings to sentence case, 'via' → 'using', 'a SAP' → 'an SAP', 'Please note' → 'Note that', missing comma before 'which' - Add code fence language tag (text) to WebIDEUsage snippet - Fix H2 verb parallelism: 'Deploy' → 'Deploying It' - Add Key Notes from the Tutorial section covering connectivity overview, destination configuration (with OAuth2UserTokenExchange and SAMLAssertion examples), cross-subaccount requirements including SAML trust certificate setup, roles and authorizations, service discovery, and common failure patterns
🔗 Link Check ResultsThe link checker has completed. This is an optional check and will not block the PR. If broken links were found, please review them at your convenience. Last updated: Run #178 at 2026-04-15T13:44:04Z |
- Clarify connectivity overview: odata_abap usage, URL must be base host only, BAS Cloud Foundry org/space prerequisite - Add WebIDEEnabled and HTML5.DynamicDestination as required destination properties - Add Environment Check as primary troubleshooting validation step with steps sourced from misc/destinations README - Split Troubleshooting into two subsections: Environment Check and connectivity trace - Tighten service discovery description to reference odata_abap behavior explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
misc/abapcloud/README.md(multiple H1s, bare code fence, trailing spaces, missing blank lines)via→using,a SAP→an SAP,Please note→Note that, missing comma, code fence language tagOAuth2UserTokenExchangeandSAMLAssertionexample JSON (obfuscated)Test plan
npx markdownlint-cli misc/abapcloud/README.mdpasses with no outputviausage remains; noa SAParticle errors remain